Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dcn/fix windows fs bug #368

Merged
merged 28 commits into from
Oct 3, 2024
Merged

Dcn/fix windows fs bug #368

merged 28 commits into from
Oct 3, 2024

Conversation

DanielC-N
Copy link
Contributor

  • fixed a bug that made the PDF generator to crash on windows.
  • fixed few bugs with Gitea
  • updated jxl-pdf

danielc-n added 11 commits September 17, 2024 10:23
@selvabenz
Copy link

Documentation purpose only: this PR throws this error and unable to build the Windows package.
Screenshot from 2024-09-24 16-56-00

1 similar comment
@selvabenz
Copy link

Documentation purpose only: this PR throws this error and unable to build the Windows package.
Screenshot from 2024-09-24 16-56-00

danielc-n added 17 commits September 25, 2024 11:29
FIXED pdf generation for windows
b0473ea
fixes and updated the module to make it easier to use
cc51526
corrected eslint
4279920
fixed list of book display
c67ba5d
modified the code to avoid deleting all the wrappers in the list. Whe…
b5091ea 
…n you only have one item in a list, you cannot delete it anymore
removed useless console.log
126b9d6
eslint fix
8f65591
slight text change
3b4e1ad
installed 'puppeteer for electron' , we will now instanciate the brow…
23a491c 
…ser with puppeteer-core and give the instance to jxl-pdf
it's now install chrome automatically for puppeteer-core
a98307f
installed graceful-fs and removed useless files and updated github ac…
5ea1101 
…tion
test to build actions for dcn/fix_windows_fs_bug
02b264a
getting rid of 'graceful-fs' and everything is working here
f62e774
resolved last eslint error
a2750dd
removed my branch from yml file
d89c935
fixed macos install yaml
56e16fe
last fix for this to work on all platforms
ec5758f
@selvabenz
Copy link

@DanielC-N thanks for the fixes. @vipinpaul, this PR can be merged, all the functions are working as expected.
image

@vipinpaul vipinpaul merged commit 8addbea into bible-technology:development Oct 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vipinpaul vipinpaul vipinpaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielC-N @selvabenz @vipinpaul